-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): simply support trigger manual compaction and risectl #3218
Conversation
b74a99b
to
2a0ebe7
Compare
I found a bug that: how to resolve this ? |
Codecov Report
@@ Coverage Diff @@
## main #3218 +/- ##
==========================================
- Coverage 73.41% 73.39% -0.02%
==========================================
Files 744 745 +1
Lines 101665 101873 +208
==========================================
+ Hits 74634 74769 +135
- Misses 27031 27104 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
} | ||
} | ||
|
||
tracing::trace!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change the log level to info, otherwise in release mode this won't be printed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix it
2a0ebe7
to
a1582ac
Compare
What's changed and what's your intention?
simply support trigger manual compaction
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)