-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): Implement parsing of SINK statement #3219
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…data/risingwave-dev into ns-sink-write-batch
…data/risingwave-dev into ns-sink-write-batch
Codecov Report
@@ Coverage Diff @@
## main #3219 +/- ##
=======================================
Coverage 73.48% 73.48%
=======================================
Files 746 746
Lines 101957 101992 +35
=======================================
+ Hits 74923 74952 +29
- Misses 27034 27040 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed and what's your intention?
Added implementation of SINK statement parsing.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Following statement is now allowed:
IF NOT EXISTS
is optional.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)