Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(batch scheduler): some style improvements #3221

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 14, 2022

What's changed and what's your intention?

as title. also improved/fixed some comments

Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3221 (346fc3b) into main (a4aab7a) will increase coverage by 0.01%.
The diff coverage is 23.65%.

@@            Coverage Diff             @@
##             main    #3221      +/-   ##
==========================================
+ Coverage   73.48%   73.50%   +0.01%     
==========================================
  Files         746      746              
  Lines      101957   101925      -32     
==========================================
- Hits        74923    74915       -8     
+ Misses      27034    27010      -24     
Flag Coverage Δ
rust 73.50% <23.65%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/scheduler/distributed/query_manager.rs 11.32% <ø> (ø)
src/frontend/src/scheduler/local.rs 0.00% <0.00%> (ø)
src/frontend/src/scheduler/mod.rs 0.00% <ø> (ø)
src/frontend/src/scheduler/distributed/stage.rs 49.16% <14.28%> (+1.96%) ⬆️
src/frontend/src/scheduler/distributed/query.rs 69.05% <40.00%> (+1.85%) ⬆️
src/frontend/src/scheduler/plan_fragmenter.rs 93.68% <100.00%> (+0.04%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang TennyZhuang merged commit 6e7ca58 into main Jun 15, 2022
@TennyZhuang TennyZhuang deleted the xxchan/scheduler-style branch June 15, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants