Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): disable compaction filter temporarily. #3234

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 15, 2022

What's changed and what's your intention?

This PR temporarily disables compaction filter.

Compaction filter relies on compaction group manager to provide existing_table_ids. Current source is not in existing_table_ids, so its state(used in failover) can be incorrectly removed by compaction filter.

Checklist

Refer to a related PR or issue link (optional)

@zwang28 zwang28 requested a review from Li0k June 15, 2022 05:56
@github-actions github-actions bot added the type/fix Bug fix label Jun 15, 2022
@zwang28 zwang28 marked this pull request as ready for review June 15, 2022 05:57
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zwang28 zwang28 enabled auto-merge (squash) June 15, 2022 06:06
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #3234 (7f9a855) into main (c86f7e2) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3234      +/-   ##
==========================================
- Coverage   73.57%   73.37%   -0.21%     
==========================================
  Files         745      745              
  Lines      102290   102290              
==========================================
- Hits        75263    75052     -211     
- Misses      27027    27238     +211     
Flag Coverage Δ
rust 73.37% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/compactor_tests.rs 35.88% <ø> (-56.10%) ⬇️
src/storage/src/hummock/compactor.rs 72.44% <100.00%> (-2.33%) ⬇️
src/storage/src/hummock/state_store.rs 77.53% <0.00%> (-7.70%) ⬇️
src/meta/src/hummock/compaction/mod.rs 77.41% <0.00%> (-1.94%) ⬇️
src/storage/src/hummock/mod.rs 84.21% <0.00%> (-1.32%) ⬇️
src/storage/src/hummock/utils.rs 93.18% <0.00%> (-1.14%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 42.39% <0.00%> (-1.09%) ⬇️
src/meta/src/model/mod.rs 98.10% <0.00%> (-0.64%) ⬇️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zwang28 zwang28 merged commit 9ef80da into main Jun 15, 2022
@zwang28 zwang28 deleted the wangzheng/chore_disable_compaction_filter branch June 15, 2022 06:07
zwang28 added a commit that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants