Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(binder): split type_inference to smaller files #3244

Merged
merged 5 commits into from
Jun 15, 2022

Conversation

xiangjinwu
Copy link
Contributor

What's changed and what's your intention?

As title.

Checklist

- [ ] I have written necessary docs and comments

  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 850 files.

Valid Invalid Ignored Fixed
847 2 1 0
Click to see the invalid file list
  • src/frontend/src/expr/type_inference/cast.rs
  • src/frontend/src/expr/type_inference/func.rs

src/frontend/src/expr/type_inference/cast.rs Show resolved Hide resolved
src/frontend/src/expr/type_inference/func.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #3244 (2bf72f7) into main (2ad3a5b) will increase coverage by 0.00%.
The diff coverage is 99.52%.

@@           Coverage Diff           @@
##             main    #3244   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         745      747    +2     
  Lines      101837   101837           
=======================================
+ Hits        74566    74567    +1     
+ Misses      27271    27270    -1     
Flag Coverage Δ
rust 73.22% <99.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/expr/type_inference/func.rs 98.67% <ø> (ø)
src/frontend/src/expr/type_inference/mod.rs 94.73% <94.73%> (ø)
src/frontend/src/expr/type_inference/cast.rs 100.00% <100.00%> (ø)
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiangjinwu xiangjinwu marked this pull request as ready for review June 15, 2022 08:01
@xiangjinwu xiangjinwu merged commit e2b8b35 into main Jun 15, 2022
@xiangjinwu xiangjinwu deleted the refactor-split-type-inference branch June 15, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants