feat(hummock): introduce aligned allocator and cache file skeleton #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCroxx
force-pushed
the
xx/file-cache-system-p1
branch
from
020dcac
to
16ee3a6
Compare
MrCroxx
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3250 +/- ##
==========================================
+ Coverage 73.22% 73.24% +0.02%
==========================================
Files 748 753 +5
Lines 101994 102280 +286
==========================================
+ Hits 74686 74920 +234
- Misses 27308 27360 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
MrCroxx
requested review from
hzxa21,
TennyZhuang,
fuyufjh,
Li0k and
Little-Wallace
|
Maybe this PR is too immature, but I want to keep each PR small and easy to review, QwQ. |
TennyZhuang
reviewed
Jun 16, 2022
|
LGTM for the allocator part. I haven't enough background knowledge to review the PR ( |
TennyZhuang
reviewed
Jun 16, 2022
fuyufjh
approved these changes
Jun 16, 2022
hzxa21
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This is a one of the PRs for the file cache system, to avoid sending a huge PR all at once.
AlignedAllocatorfor direct I/O buffer allocation.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
#198