Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(meta): remove NothingMutation #3256

Merged
merged 1 commit into from
Jun 15, 2022
Merged

style(meta): remove NothingMutation #3256

merged 1 commit into from
Jun 15, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 15, 2022

What's changed and what's your intention?

use None instead

Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@xxchan xxchan enabled auto-merge (squash) June 15, 2022 14:08
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #3256 (1ebdd57) into main (4f0ef58) will increase coverage by 0.00%.
The diff coverage is 21.00%.

@@           Coverage Diff           @@
##             main    #3256   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         747      747           
  Lines      101892   101892           
=======================================
+ Hits        74611    74614    +3     
+ Misses      27281    27278    -3     
Flag Coverage Δ
rust 73.22% <21.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/stream/source_manager.rs 26.23% <0.00%> (ø)
src/stream/src/executor/mod.rs 49.65% <17.85%> (+1.02%) ⬆️
src/meta/src/barrier/command.rs 75.59% <100.00%> (ø)
src/meta/src/barrier/mod.rs 70.23% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxchan xxchan requested a review from yezizp2012 June 15, 2022 15:12
Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan merged commit c824303 into main Jun 15, 2022
@xxchan xxchan deleted the xxchan/no-mutation branch June 15, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants