Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): clean up unused fields #3261

Merged
merged 1 commit into from
Jun 16, 2022
Merged

refactor(batch): clean up unused fields #3261

merged 1 commit into from
Jun 16, 2022

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 16, 2022

What's changed and what's your intention?

source_idx: usize,
current_source: Option<Box>,

unused.

first_execution

Not needed anymore as async fn do_execute(mut self: Box<Self>) { is implemented by async_stream

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@lmatz lmatz enabled auto-merge (squash) June 16, 2022 03:39
@lmatz lmatz merged commit b2ae9f3 into main Jun 16, 2022
@lmatz lmatz deleted the lz/refactor branch June 16, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants