Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meta): make vnodes sequential in initial hash mapping #3263

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

xx01cyx
Copy link
Contributor

@xx01cyx xx01cyx commented Jun 16, 2022

What's changed and what's your intention?

Summarize your change

Alter strategy of assigning vnodes to parallel unit when generating vnode mappings, so that initial vnode mapping will look like:

[1,1,1,1,2,2,2,2,3,3,3,3,4,4,4]

instead of

[1,1,1,2,2,2,3,3,3,4,4,4,1,2,3]

In this way:

  • The compression could achieve better effects.
  • It looks prettier.

Checklist

  • All checks passed in ./risedev check (or alias, ./risedev c)

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #3263 (1c2b6e3) into main (c824303) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3263      +/-   ##
==========================================
- Coverage   73.22%   73.22%   -0.01%     
==========================================
  Files         747      747              
  Lines      101892   101888       -4     
==========================================
- Hits        74614    74608       -6     
- Misses      27278    27280       +2     
Flag Coverage Δ
rust 73.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/manager/hash_mapping.rs 97.35% <100.00%> (-0.04%) ⬇️
src/meta/src/barrier/mod.rs 69.94% <0.00%> (-0.30%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xx01cyx xx01cyx changed the title chore(meta): alter strategy of assigning vnodes to parallel unit chore(meta): make vnodes sequential in initial hash mapping Jun 16, 2022
@xx01cyx xx01cyx merged commit 26e1397 into main Jun 16, 2022
@xx01cyx xx01cyx deleted the cyx/assign-vnode-strategy branch June 16, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants