Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): remove source when there is a from attribute #3267

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 16, 2022

What's changed and what's your intention?

The #[from] attribute always implies that the same field is #[source], so you don't ever need to specify both attributes.

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@lmatz lmatz changed the title refactor(frontend): remove source when there is a from attribute refactor(storage): remove source when there is a from attribute Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #3267 (ca0c123) into main (c824303) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
- Coverage   73.22%   73.22%   -0.01%     
==========================================
  Files         747      747              
  Lines      101892   101892              
==========================================
- Hits        74614    74613       -1     
- Misses      27278    27279       +1     
Flag Coverage Δ
rust 73.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object_store/src/object/error.rs 33.33% <ø> (ø)
src/storage/src/error.rs 0.00% <ø> (ø)
src/meta/src/barrier/mod.rs 69.94% <0.00%> (-0.30%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lmatz lmatz enabled auto-merge (squash) June 16, 2022 06:48
@lmatz lmatz merged commit 53a49d8 into main Jun 16, 2022
@lmatz lmatz deleted the lz/refactor branch June 16, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants