refactor(storage): simplify state table iter with async stream #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
changed the title
BugenZhao
changed the title
xxchan
approved these changes
Jun 16, 2022
| // (st1page): Maybe we will have a "ChunkIter" trait which returns a chunk each time, so the name | ||
| // "RowTableIter" is reserved now | ||
| pub struct CellBasedTableRowIter<S: StateStore> { | ||
| /// [`CellBasedIter`] iterates on the cell-based table. |
There was a problem hiding this comment.
I'm afraid the clippy will complain about this. 😁
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
|
Leave me some time to review this PR😊 |
Codecov Report
@@ Coverage Diff @@
## main #3272 +/- ##
==========================================
- Coverage 73.23% 73.22% -0.01%
==========================================
Files 747 748 +1
Lines 101789 101767 -22
==========================================
- Hits 74545 74523 -22
Misses 27244 27244
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao i@bugenzhao.com
What's changed and what's your intention?
As title. The diff of
cell_based_tableis totally unreadable, please review the latest version. 🤣Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)