refactor: use bounded channel for 3 channels #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmatz
approved these changes
Jun 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #3273 +/- ##
==========================================
- Coverage 73.23% 73.22% -0.01%
==========================================
Files 747 747
Lines 101789 101794 +5
==========================================
- Hits 74545 74543 -2
- Misses 27244 27251 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Comment on lines
+38
to
+42
| for sender in &self.senders { | ||
| sender | ||
| .send(chunk.clone()) | ||
| .to_rw_result_with(|| "BroadcastSender::send".into()) | ||
| }) | ||
| .await | ||
| .to_rw_result_with(|| "BroadcastSender::send".into())?; |
There was a problem hiding this comment.
Should we send this in parallel?
There was a problem hiding this comment.
Yes I thought about this. What about done this in anthor PR? Prevoius it is also not parallel.
| @@ -122,17 +123,22 @@ impl HashShuffleSender { | |||
| if new_data_chunk.cardinality() > 0 { | |||
| self.senders[sink_id] | |||
| .send(Some(new_data_chunk)) | |||
| .await | |||
There was a problem hiding this comment.
Send it in parallel.
liurenjie1024
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
ref: #3024
For 3 channels:
FIFO, HASH, BROADCAST
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)