Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pgwire): fix the wrong typeOID of Decimal type #3280

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Jun 16, 2022

What's changed and what's your intention?

  • fix the wrong typeOID of Decimal type.
  • Add the comment to avoid bug like this in the future.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#3015

@github-actions github-actions bot added the type/fix Bug fix label Jun 16, 2022
Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BowenXiao1999 BowenXiao1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @xiangjinwu, PTAL

Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #3280 (bd1a349) into main (53a49d8) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3280      +/-   ##
==========================================
- Coverage   73.23%   73.23%   -0.01%     
==========================================
  Files         747      747              
  Lines      101789   101789              
==========================================
- Hits        74545    74543       -2     
- Misses      27244    27246       +2     
Flag Coverage Δ
rust 73.23% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/pgwire/src/pg_field_descriptor.rs 76.92% <0.00%> (ø)
src/meta/src/hummock/mock_hummock_meta_client.rs 41.48% <0.00%> (-1.07%) ⬇️
src/storage/src/hummock/local_version_manager.rs 83.86% <0.00%> (-0.16%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ZENOTME ZENOTME merged commit 279d39d into main Jun 16, 2022
@ZENOTME ZENOTME deleted the zej/fix_decimal_typeOID branch June 16, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants