Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): fix append_only top_n #3290

Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix(stream): fix append_only top_n #3290

merged 1 commit into from
Jun 17, 2022

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Jun 17, 2022

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #3286

@wcy-fdu wcy-fdu requested a review from StrikeW June 17, 2022 03:51
@github-actions github-actions bot added the type/fix Bug fix label Jun 17, 2022
@wcy-fdu wcy-fdu enabled auto-merge (squash) June 17, 2022 03:54
@wcy-fdu wcy-fdu merged commit f9d3ba8 into main Jun 17, 2022
@wcy-fdu wcy-fdu deleted the wcy_fix_append_only_top_n branch June 17, 2022 04:01
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #3290 (b512f20) into main (d577da0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3290      +/-   ##
==========================================
- Coverage   73.23%   73.22%   -0.01%     
==========================================
  Files         748      748              
  Lines      101766   101766              
==========================================
- Hits        74525    74523       -2     
- Misses      27241    27243       +2     
Flag Coverage Δ
rust 73.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/top_n_appendonly.rs 95.07% <100.00%> (ø)
src/meta/src/barrier/mod.rs 69.94% <0.00%> (-0.30%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streaming: append-only TopN panic
2 participants