feat: implement infer_return_type in frontend #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
- Coverage 73.23% 73.21% -0.02%
==========================================
Files 748 748
Lines 101766 101785 +19
==========================================
+ Hits 74524 74525 +1
- Misses 27242 27260 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BowenXiao1999
approved these changes
Jun 17, 2022
| } | ||
|
|
||
| fn user_authenticator(&self) -> &UserAuthenticator { | ||
| &self.user_authenticator | ||
| } | ||
| } | ||
|
|
||
| fn infer(session: Arc<SessionImpl>, stmt: Statement) -> Result<Vec<PgFieldDescriptor>> { |
|
@ZENOTME I assume the implementation change is invisible to users. Correct? Thanks. |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
The original implementation of infer_return_type interface in frontend is copied from run_statement. It will actually execute the statement and get the result description from the result of execution. This implementation is primarily for testing purposes but it's inefficient. Infer_return_type API is to get the result description but needn't execute.
Hence we give a new implementation for infer_return_type. It calls a new function "infer", "infer" will get the result description
of the query statement but not execute.
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
#3131