Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): auto build ci image #3372

Merged
merged 2 commits into from
Jun 21, 2022
Merged

chore(ci): auto build ci image #3372

merged 2 commits into from
Jun 21, 2022

Conversation

huangjw806
Copy link
Contributor

@huangjw806 huangjw806 commented Jun 21, 2022

What's changed and what's your intention?

As per the title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

issue: #2898

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Please also help check permission of those keys / IAMs, only main branch or PR triggered by org member should be able to get them.
  • If AWS supports tag immutability, we should enable it, so that one tag only corresponds to one image.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #3372 (2e25f76) into main (dac904e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3372      +/-   ##
==========================================
- Coverage   73.74%   73.74%   -0.01%     
==========================================
  Files         760      760              
  Lines      104139   104139              
==========================================
- Hits        76798    76796       -2     
- Misses      27341    27343       +2     
Flag Coverage Δ
rust 73.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 41.74% <0.00%> (-0.98%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.37% <0.00%> (-0.16%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@huangjw806 huangjw806 merged commit 3e94ca3 into main Jun 21, 2022
@huangjw806 huangjw806 deleted the huangjw/auto-build-ci-image branch June 21, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants