Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): remove redundant request to meta in frontend #3376

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

xx01cyx
Copy link
Contributor

@xx01cyx xx01cyx commented Jun 21, 2022

What's changed and what's your intention?

Since we have notification service now, frontend need not query meta by itself on initialization.

Checklist

  • All checks passed in ./risedev check (or alias, ./risedev c)

@github-actions github-actions bot added the type/fix Bug fix label Jun 21, 2022
Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xx01cyx xx01cyx enabled auto-merge (squash) June 21, 2022 06:56
@xx01cyx xx01cyx merged commit 198bf4f into main Jun 21, 2022
@xx01cyx xx01cyx deleted the cyx/remove-fe-unused-list branch June 21, 2022 07:05
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #3376 (b8e1cd8) into main (c37c9c4) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3376      +/-   ##
==========================================
+ Coverage   73.72%   73.73%   +0.01%     
==========================================
  Files         760      760              
  Lines      104272   104262      -10     
==========================================
+ Hits        76872    76877       +5     
+ Misses      27400    27385      -15     
Flag Coverage Δ
rust 73.73% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/scheduler/worker_node_manager.rs 79.45% <0.00%> (ø)
src/frontend/src/session.rs 41.54% <0.00%> (-0.21%) ⬇️
src/rpc_client/src/meta_client.rs 0.00% <ø> (ø)
src/sqlparser/src/ast/mod.rs 88.86% <0.00%> (+0.11%) ⬆️
src/storage/src/hummock/local_version_manager.rs 84.53% <0.00%> (+0.15%) ⬆️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants