-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): store internal table catalog in meta. #3389
Conversation
We still have to take |
Codecov Report
@@ Coverage Diff @@
## main #3389 +/- ##
==========================================
- Coverage 73.83% 73.75% -0.08%
==========================================
Files 765 766 +1
Lines 105450 105457 +7
==========================================
- Hits 77856 77783 -73
- Misses 27594 27674 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@@ -90,9 +92,17 @@ impl SchemaCatalog { | |||
|
|||
/// Iterate all materialized views, excluding the indexs. | |||
pub fn iter_mv(&self) -> impl Iterator<Item = &TableCatalog> { | |||
lazy_static! { | |||
static ref INTERNAL_TABLE_NAME: Regex = Regex::new(r"__INTERNAL_.*_\d+").unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving internal table naming logic and verify into common crate? Besides, we should also provide a valid_table_name(&str) -> bool
function, to validate normal created table.
src/meta/src/stream/stream_graph.rs
Outdated
@@ -530,13 +538,18 @@ impl StreamGraphBuilder { | |||
stream_node: &StreamNode, | |||
actor_id: LocalActorId, | |||
upstream_actor_id: &mut HashMap<u64, OrderedActorLink>, | |||
) -> Result<StreamNode> { | |||
) -> Result<(StreamNode, Vec<Table>)> { | |||
fn generate_intertable_name(mview_name: &String, table_id: u32) -> String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
following #3139, this is the meta part, including:
SHOW MATERIALIZED VIEW
.update:
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
close #3053