Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(risedev): fix install-tools #3410

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix(risedev): fix install-tools #3410

merged 1 commit into from
Jun 22, 2022

Conversation

wangrunji0408
Copy link
Contributor

@wangrunji0408 wangrunji0408 commented Jun 22, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

About 4 hours ago, cargo_metadata released 0.14.3 which broke semantic versioning and caused ./risedev install-tools to fail. 馃お

error[E0277]: the trait bound `Box<str>: From<Edition>` is not satisfied
   --> /Users/wangrunji/.cargo/registry/src/github.com-1ecc6299db9ec823/guppy-0.14.2/src/graph/build.rs:328:42
    |
328 |                 edition: package.edition.into(),
    |                                          ^^^^ the trait `From<Edition>` is not implemented for `Box<str>`
    |
    = help: the following other types implement trait `From<T>`:
              <Box<(dyn StdError + 'a)> as From<E>>
              <Box<(dyn StdError + 'static)> as From<&str>>
              <Box<(dyn StdError + 'static)> as From<Cow<'a, str>>>
              <Box<(dyn StdError + 'static)> as From<std::string::String>>
              <Box<(dyn StdError + Send + Sync + 'a)> as From<&str>>
              <Box<(dyn StdError + Send + Sync + 'a)> as From<Cow<'b, str>>>
              <Box<(dyn StdError + Send + Sync + 'a)> as From<E>>
              <Box<(dyn StdError + Send + Sync + 'static)> as From<std::string::String>>
            and 22 others
    = note: required because of the requirements on the impl of `Into<Box<str>>` for `Edition`

error[E0599]: no method named `into_boxed_str` found for enum `Edition` in the current scope
   --> /Users/wangrunji/.cargo/registry/src/github.com-1ecc6299db9ec823/guppy-0.14.2/src/graph/build.rs:519:45
    |
519 |                     edition: target.edition.into_boxed_str(),
    |                                             ^^^^^^^^^^^^^^ method not found in `Edition`

Some errors have detailed explanations: E0277, E0599.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `guppy` due to 2 previous errors

This PR fixes this issue by adding --locked to cargo install.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@wangrunji0408 wangrunji0408 requested a review from skyzh June 22, 2022 12:52
@github-actions github-actions bot added the type/fix Bug fix label Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #3410 (65fe08f) into main (3ab970c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3410   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         766      766           
  Lines      104879   104879           
=======================================
  Hits        77175    77175           
  Misses      27704    27704           
Flag Coverage 螖
rust 73.58% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
src/meta/src/hummock/mock_hummock_meta_client.rs 40.56% <0.00%> (-0.95%) 猬囷笍
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) 猬囷笍
src/storage/src/hummock/local_version_manager.rs 84.37% <0.00%> (-0.16%) 猬囷笍
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) 猬嗭笍
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.50%) 猬嗭笍

馃摚 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 22, 2022
@mergify mergify bot merged commit 5f769d6 into main Jun 22, 2022
@mergify mergify bot deleted the wrj/fix-install-tools branch June 22, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants