Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): compress debug info in docker builds #3413

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 23, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, 1GB -> 300MB

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh marked this pull request as ready for review June 23, 2022 03:17
@huangjw806
Copy link
Contributor

LGTM!

@arkbriar
Copy link
Contributor

LGTM!

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3413 (2f6b95f) into main (4514615) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3413      +/-   ##
==========================================
- Coverage   73.59%   73.59%   -0.01%     
==========================================
  Files         765      765              
  Lines      104937   104937              
==========================================
- Hits        77232    77231       -1     
- Misses      27705    27706       +1     
Flag Coverage Δ
rust 73.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 40.56% <0.00%> (-0.95%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.37% <0.00%> (-0.16%) ⬇️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.25%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 23, 2022
@mergify mergify bot merged commit 3183b69 into main Jun 23, 2022
@mergify mergify bot deleted the skyzh/compress-debug-section-docker branch June 23, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants