feat(config): support extra_float_digits #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
approved these changes
Jun 23, 2022
|
What about an e2e test to prevent regression? |
lmatz
added
the
mergify/can-merge
Codecov Report
@@ Coverage Diff @@
## main #3417 +/- ##
=======================================
Coverage 73.59% 73.59%
=======================================
Files 765 765
Lines 104937 104938 +1
=======================================
+ Hits 77232 77233 +1
Misses 27705 27705
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As linked in #3406, this is a no-op for now. And in most cases, the default usage is to set it as 3 to get the shortest-precise float as the text output, i.e. Sqlancer, and JDBC mentioned in #3293.
Since we may need to fully support it in the future, #3406 will be kept.
Checklist
- [ ] I have added necessary unit tests and integration tests./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
closes #3293