Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meta): deprecate VirtualTable in catalog.proto #3423

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jun 23, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3423 (c140107) into main (ec32030) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
- Coverage   73.59%   73.59%   -0.01%     
==========================================
  Files         765      765              
  Lines      104938   104937       -1     
==========================================
- Hits        77231    77230       -1     
  Misses      27707    27707              
Flag Coverage Δ
rust 73.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/rpc/service/notification_service.rs 0.00% <ø> (ø)
src/meta/src/barrier/mod.rs 69.29% <0.00%> (-0.30%) ⬇️
src/frontend/src/expr/utils.rs 98.74% <0.00%> (-0.26%) ⬇️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 marked this pull request as ready for review June 23, 2022 06:56
@yezizp2012 yezizp2012 enabled auto-merge (squash) June 23, 2022 06:56
@@ -131,7 +131,6 @@ message MetaSnapshot {
repeated catalog.Schema schema = 3;
repeated catalog.Source source = 4;
repeated catalog.Table table = 5;
repeated catalog.VirtualTable view = 6;
repeated user.UserInfo users = 7;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repeated user.UserInfo users = 7;
repeated user.UserInfo users = 6;

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@yezizp2012 yezizp2012 merged commit 9971021 into main Jun 23, 2022
@yezizp2012 yezizp2012 deleted the feat/rm-virtual-table branch June 23, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants