Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): fix bug of lease #3435

Merged
merged 9 commits into from
Jun 24, 2022

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Jun 23, 2022

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #3398
and add test for lease.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3435 (9223ce5) into main (118540a) will increase coverage by 0.51%.
The diff coverage is 98.14%.

@@            Coverage Diff             @@
##             main    #3435      +/-   ##
==========================================
+ Coverage   73.74%   74.26%   +0.51%     
==========================================
  Files         768      768              
  Lines      106454   106499      +45     
==========================================
+ Hits        78505    79088     +583     
+ Misses      27949    27411     -538     
Flag Coverage Δ
rust 74.26% <98.14%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/rpc/server.rs 80.18% <98.14%> (+80.18%) ⬆️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.53% <0.00%> (+0.15%) ⬆️
src/meta/src/manager/catalog.rs 19.96% <0.00%> (+0.16%) ⬆️
src/meta/src/manager/user.rs 88.11% <0.00%> (+0.25%) ⬆️
src/meta/src/hummock/hummock_manager.rs 85.61% <0.00%> (+0.28%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️
src/meta/src/manager/id.rs 96.62% <0.00%> (+2.24%) ⬆️
src/meta/src/manager/notification.rs 51.74% <0.00%> (+2.79%) ⬆️
src/meta/src/rpc/service/ddl_service.rs 3.43% <0.00%> (+3.43%) ⬆️
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@twocode
Copy link
Contributor

twocode commented Jun 23, 2022

cc @vdnhi for hitting this.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace Little-Wallace enabled auto-merge (squash) June 24, 2022 06:15
@Little-Wallace Little-Wallace merged commit d1d5523 into risingwavelabs:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta restart fail due to panic on keep lease failed, another node has become new leader
4 participants