Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): better nextest config #3436

Merged
merged 7 commits into from
Jun 23, 2022
Merged

chore(ci): better nextest config #3436

merged 7 commits into from
Jun 23, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 23, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Tweak nextest config, so that it can be more useful. Also produce junit file so that it can integrate with Buildkite's test analytics better.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh marked this pull request as ready for review June 23, 2022 11:19
@skyzh skyzh requested a review from TennyZhuang June 23, 2022 11:19
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 23, 2022
@skyzh
Copy link
Contributor Author

skyzh commented Jun 23, 2022

Also enabled Test Analytics of Buildkite, so that we can know more about our unit tests...

https://buildkite.com/organizations/singularity-data/analytics/suites/unit-test

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3436 (dd3204e) into main (f1c7a2d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3436      +/-   ##
==========================================
- Coverage   73.81%   73.81%   -0.01%     
==========================================
  Files         765      765              
  Lines      105357   105357              
==========================================
- Hits        77769    77767       -2     
- Misses      27588    27590       +2     
Flag Coverage Δ
rust 73.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit c88f830 into main Jun 23, 2022
@mergify mergify bot deleted the skyzh/nextest-config branch June 23, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants