refactor(batch): Remove panic in getting catalog reader. #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Jun 24, 2022
| fn sys_catalog_reader_ref(&self) -> Option<SysCatalogReaderRef>; | ||
| fn catalog_reader_ref(&self) -> Option<SysCatalogReaderRef>; | ||
|
|
||
| fn try_get_catalog_reader_ref(&self) -> Result<SysCatalogReaderRef> { |
There was a problem hiding this comment.
In what case will catalog reader be None?
There was a problem hiding this comment.
When it's executed in compute node.
Codecov Report
@@ Coverage Diff @@
## main #3451 +/- ##
=======================================
Coverage 74.27% 74.27%
=======================================
Files 768 768
Lines 106619 106623 +4
=======================================
+ Hits 79191 79195 +4
Misses 27428 27428
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
RT
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)