Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine(dashboard): layout and loading indicator #3455

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

shhdgit
Copy link
Contributor

@shhdgit shhdgit commented Jun 24, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Fix page flashing caused by loading wrapper.
  • Add layout title and fix nav item animation

From:
image
image

To:
image

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Suhaha <jklopsdfw@gmail.com>
Signed-off-by: Suhaha <jklopsdfw@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2022

CLA assistant check
All committers have signed the CLA.

@shhdgit shhdgit changed the title Refine dashboard refine(dashboard): layout and loading indicator Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #3455 (3a3d751) into main (91a6990) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3455      +/-   ##
==========================================
- Coverage   74.27%   74.27%   -0.01%     
==========================================
  Files         768      768              
  Lines      106623   106623              
==========================================
- Hits        79196    79193       -3     
- Misses      27427    27430       +3     
Flag Coverage Δ
rust 74.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/mock_hummock_meta_client.rs 40.56% <0.00%> (-0.95%) ⬇️
src/frontend/src/expr/utils.rs 98.99% <0.00%> (-0.26%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.37% <0.00%> (-0.16%) ⬇️
src/meta/src/manager/id.rs 95.50% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@mikechesterwang mikechesterwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikechesterwang mikechesterwang enabled auto-merge (squash) June 25, 2022 07:18
@mikechesterwang mikechesterwang merged commit 6717178 into risingwavelabs:main Jun 25, 2022
@shhdgit shhdgit deleted the refine-dashboard branch June 25, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants