Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): fix warning from source manager when drop materialized source #3480

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Jun 27, 2022

Signed-off-by: Peng Chen peng@singularity-data.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#3473

@shanicky shanicky linked an issue Jun 27, 2022 that may be closed by this pull request
@github-actions github-actions bot added the type/fix Bug fix label Jun 27, 2022
…ource

Signed-off-by: Peng Chen <peng@singularity-data.com>
@shanicky shanicky force-pushed the peng/3473-dropping-source-while-associated-fragments-still-exist branch from 28c9b1c to 80f3f7f Compare June 27, 2022 05:45
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanicky shanicky enabled auto-merge (squash) June 27, 2022 05:54
@shanicky shanicky merged commit 7808cac into main Jun 27, 2022
@shanicky shanicky deleted the peng/3473-dropping-source-while-associated-fragments-still-exist branch June 27, 2022 05:57
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3480 (80f3f7f) into main (726fc3c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3480      +/-   ##
==========================================
- Coverage   74.40%   74.40%   -0.01%     
==========================================
  Files         769      769              
  Lines      107303   107304       +1     
==========================================
  Hits        79841    79841              
- Misses      27462    27463       +1     
Flag Coverage Δ
rust 74.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/rpc/service/ddl_service.rs 3.48% <0.00%> (ø)
src/meta/src/stream/source_manager.rs 30.60% <0.00%> (-0.07%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropping source while associated fragments still exist
2 participants