-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(relational_states): use fe table catalog for hash agg #3484
Conversation
6090289
to
7efb344
Compare
Codecov Report
@@ Coverage Diff @@
## main #3484 +/- ##
==========================================
- Coverage 74.43% 74.36% -0.07%
==========================================
Files 769 769
Lines 107554 107397 -157
==========================================
- Hits 80060 79870 -190
- Misses 27494 27527 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
e1f1a88
to
78f9452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @BowenXiao1999, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
7081bc5
to
c542d8d
Compare
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
infer_internal_table_catalog
. Done some Simple DRY. Previous code is hard to maintain and read... May need more work in future.Part of #3475
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)