feat(frontend): implementation for create/drop sink handlers #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nanderstabel
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3488 +/- ##
==========================================
+ Coverage 74.31% 74.35% +0.03%
==========================================
Files 773 775 +2
Lines 109868 110074 +206
==========================================
+ Hits 81647 81843 +196
- Misses 28221 28231 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
neverchanje
reviewed
Jul 4, 2022
| @@ -34,6 +37,10 @@ pub struct SchemaCatalog { | |||
| source_by_name: HashMap<String, SourceCatalog>, | |||
| source_name_by_id: HashMap<SourceId, String>, | |||
|
|
|||
| // TODO(nanderstabel): Can be replaced with a bijective map: https://crates.io/crates/bimap. | |||
neverchanje
reviewed
Jul 4, 2022
| @@ -84,7 +84,7 @@ pub fn handle_show_object(context: OptimizerContext, command: ShowObject) -> Res | |||
| .iter_materialized_source() | |||
| .map(|t| t.name.clone()) | |||
| .collect(), | |||
| ShowObject::Sink { _schema } => todo!(), | |||
| ShowObject::Sink { schema: _ } => todo!(), | |||
There was a problem hiding this comment.
Returning an unimplemented error is preferred.
neverchanje
approved these changes
Jul 4, 2022
yezizp2012
reviewed
Jul 4, 2022
| uint32 schema_id = 2; | ||
| uint32 database_id = 3; | ||
| string name = 4; | ||
| string mv_name = 5; |
There was a problem hiding this comment.
Suggested change
| string mv_name = 5; | |
| uint32 associated_table_id = 5; |
There was a problem hiding this comment.
Thank you for this suggestion, I will implement it in my next PR :)
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
tabVersion
added
the
user-facing-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add handle for CREATE SINK and DROP SINK statements as well as test_utils.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
support the following syntax
create sink {{ sink_name }} from mv/table with (...); drop sink {{ sink_name }};Refer to a related PR or issue link (optional)