refactor(source): Move field datagen to common #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 879 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 877 | 1 | 1 | 0 |
Click to see the invalid file list
- src/batch/benches/filter.rs
liurenjie1024
requested review from
skyzh
and removed request for
Little-Wallace
liurenjie1024
force-pushed
the
renjie/move_datagen_to_common
branch
from
08081e9
to
809d740
Compare
16 tasks
Codecov Report
@@ Coverage Diff @@
## main #3491 +/- ##
==========================================
- Coverage 74.39% 74.39% -0.01%
==========================================
Files 768 768
Lines 107784 107784
==========================================
- Hits 80183 80181 -2
- Misses 27601 27603 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lmatz
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Random datagen is quite useful in not only connector, but also tests. For example, we can use this data generator to generate random data for micro bench mark. So we move it from connector crate to common crate.
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)