-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hash-agg): rename distribution keys to group keys #3492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #3492 +/- ##
==========================================
+ Coverage 74.40% 74.43% +0.02%
==========================================
Files 768 769 +1
Lines 107647 107511 -136
==========================================
- Hits 80098 80024 -74
+ Misses 27549 27487 -62
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Can you paste the query? Why there are so many group keys... |
@fuyufjh cc, tpch_q2 |
Hey @BowenXiao1999, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
8490115
to
94c5b96
Compare
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As you can see in the code, when serialize "distribution_keys" in FE, it's
logical.group_keys()
. However in some cases, the dist key might be different from group keys (See the pic above, the hash agg and hash join are in same fragment). So it's better to distinguish dist keys and group keys.In future, after we done the refactor of state table, might no need to pass dist keys in each StreamNode. Ideally, we can get dist keys from state table and encode it as vnode.
ref: #3456.
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)