-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): add permission check in revoke #3512
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3512 +/- ##
========================================
Coverage 74.48% 74.48%
========================================
Files 771 771
Lines 108216 108317 +101
========================================
+ Hits 80603 80683 +80
- Misses 27613 27634 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
…risingwave into yifeng/RevokePrivilege
* add permission check in provoke * fix same user * alter option in user.proto * fix
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Check whether revoker has permission to do the revoke. Record session user and
granted by
in proto then use it inmeta
.https://www.postgresql.org/docs/current/sql-revoke.html
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)