fix: clear shared buffer on stop_all_actors #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3513 +/- ##
==========================================
+ Coverage 74.41% 74.44% +0.03%
==========================================
Files 771 770 -1
Lines 108925 108509 -416
==========================================
- Hits 81052 80778 -274
+ Misses 27873 27731 -142
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
yezizp2012
approved these changes
Jun 28, 2022
hzxa21
force-pushed
the
patrick/fix-stop-all-actors
branch
from
fffbcf0
to
fad15c8
Compare
wenym1
approved these changes
Jul 1, 2022
hzxa21
added
the
mergify/can-merge
|
Hey @hzxa21, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
hzxa21
force-pushed
the
patrick/fix-stop-all-actors
branch
from
1d0940d
to
56c8d3d
Compare
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
* fix: clear shared buffer on stop_all_actors * Use a SharedBufferEvent to clear shared buffer and pending write requests * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
During the recovery process, we stop all actors in the compute node but we miss to clear buffers in storage, which keeps the memory unreleased. This PR fixes the problem by adding a method to clear shared buffer and calling it on stop_all_actors.
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)