Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce pg_catalog.pg_matviews_info #3517

Merged
merged 6 commits into from
Jun 29, 2022
Merged

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jun 28, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Introduced a system table pg_catalog.pg_matviews_info, which contains some basic information and graph field. This's useful for cloud team to build the materialized view graph in their control panel. Below shows an example of a row, the matviewgraph field is json-encoded.

Note pg_catalog.pg_matviews_info does not exist in PostgreSQL. There is a similar one named pg_catalog.pg_matviews.

image

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3517 (cb803c1) into main (46ed9d6) will decrease coverage by 0.06%.
The diff coverage is 11.76%.

@@            Coverage Diff             @@
##             main    #3517      +/-   ##
==========================================
- Coverage   74.49%   74.43%   -0.07%     
==========================================
  Files         771      771              
  Lines      108342   108446     +104     
==========================================
+ Hits        80709    80721      +12     
- Misses      27633    27725      +92     
Flag Coverage Δ
rust 74.43% <11.76%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/meta_client.rs 0.00% <0.00%> (ø)
src/frontend/src/scheduler/task_context.rs 0.00% <0.00%> (ø)
src/frontend/src/test_utils.rs 90.76% <0.00%> (-1.71%) ⬇️
src/meta/src/barrier/mod.rs 79.87% <0.00%> (-1.33%) ⬇️
src/meta/src/stream/stream_manager.rs 76.88% <ø> (+0.80%) ⬆️
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
src/frontend/src/catalog/pg_catalog/mod.rs 8.75% <2.63%> (-5.54%) ⬇️
src/meta/src/rpc/service/stream_service.rs 20.00% <15.90%> (-22.86%) ⬇️
src/meta/src/rpc/server.rs 80.13% <100.00%> (+0.18%) ⬆️
src/meta/src/manager/id.rs 95.50% <0.00%> (ø)
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 marked this pull request as ready for review June 28, 2022 08:58
@yezizp2012 yezizp2012 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 29, 2022
@mergify mergify bot merged commit 62750cd into main Jun 29, 2022
@mergify mergify bot deleted the feat/pg_matviews_info branch June 29, 2022 05:35
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* feat: implement pg_matviews_info

* simplify graph field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants