Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): use bitmap builder for dispatcher visibility #3546

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. 💦

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #3546 (b9af523) into main (e1e27e5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3546      +/-   ##
==========================================
- Coverage   74.41%   74.41%   -0.01%     
==========================================
  Files         770      770              
  Lines      108659   108657       -2     
==========================================
- Hits        80858    80853       -5     
- Misses      27801    27804       +3     
Flag Coverage Δ
rust 74.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/dispatch.rs 77.29% <100.00%> (-0.07%) ⬇️
src/meta/src/manager/id.rs 94.94% <0.00%> (-1.13%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 40.56% <0.00%> (-0.95%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/storage/src/hummock/local_version_manager.rs 79.15% <0.00%> (-0.13%) ⬇️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️
src/storage/src/hummock/iterator/merge_inner.rs 90.00% <0.00%> (+0.62%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@chinawch007
Copy link

Excuse me, what are the functions of 'DispatchExecutor'?

@BugenZhao
Copy link
Member Author

Excuse me, what are the functions of 'DispatchExecutor'?

It's used for message passing between different streaming actors. BTW, you may join our Slack community at README.md if you are interested in RisingWave internals. 😄

@TennyZhuang
Copy link
Collaborator

Please resolve conflicts

…atcher-visibility

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 30, 2022
@chinawch007
Copy link

Excuse me, what are the functions of 'DispatchExecutor'?

It's used for message passing between different streaming actors. BTW, you may join our Slack community at README.md if you are interested in RisingWave internals. 😄

Thanks for help, I have joined the Slack community.😊

@mergify mergify bot merged commit e4c5f8b into main Jun 30, 2022
@mergify mergify bot deleted the bz/use-bitmap-in-dispatcher-visibility branch June 30, 2022 03:09
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants