feat(parser): Adds support for parsing order by in functions #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhao-su
reviewed
Jun 30, 2022
Co-authored-by: Yuhao Su <31772373+yuhao-su@users.noreply.github.com>
Co-authored-by: Yuhao Su <31772373+yuhao-su@users.noreply.github.com>
…rity-data/risingwave into steven/parsing-agg-order
BugenZhao
reviewed
Jun 30, 2022
| @@ -561,7 +561,7 @@ impl Parser { | |||
| pub fn parse_function(&mut self, name: ObjectName) -> Result<Expr, ParserError> { | |||
| self.expect_token(&Token::LParen)?; | |||
| let distinct = self.parse_all_or_distinct()?; | |||
| let args = self.parse_optional_args()?; | |||
| let (args, order_by) = self.parse_optional_args()?; | |||
There was a problem hiding this comment.
Do we need to check the function name before deciding whether ORDER BY is acceptable?
There was a problem hiding this comment.
I think it is ok to accept ORDER BY without checking the function name since Postgresql seems to do the same.
There was a problem hiding this comment.
The check can be done in binder.
Codecov Report
@@ Coverage Diff @@
## main #3566 +/- ##
=======================================
Coverage 74.38% 74.38%
=======================================
Files 771 771
Lines 108701 108714 +13
=======================================
+ Hits 80861 80872 +11
- Misses 27840 27842 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
xiangjinwu
approved these changes
Jun 30, 2022
| @@ -561,7 +561,7 @@ impl Parser { | |||
| pub fn parse_function(&mut self, name: ObjectName) -> Result<Expr, ParserError> { | |||
| self.expect_token(&Token::LParen)?; | |||
| let distinct = self.parse_all_or_distinct()?; | |||
| let args = self.parse_optional_args()?; | |||
| let (args, order_by) = self.parse_optional_args()?; | |||
There was a problem hiding this comment.
The check can be done in binder.
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
* feat(parser): Add support for parsing ORDER BY in agg functions * feat(expr): Fix typo Co-authored-by: Yuhao Su <31772373+yuhao-su@users.noreply.github.com> * feat(parser): Fix typo Co-authored-by: Yuhao Su <31772373+yuhao-su@users.noreply.github.com> * feat(parser): Fix test * feat(parser): Fix additional test * feat(parser): Throw error when using order by for table functions Co-authored-by: Yuhao Su <31772373+yuhao-su@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
Fixes #3434