Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): introduce strong type session config framework #3568

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

TennyZhuang
Copy link
Collaborator

Signed-off-by: TennyZhuang zty0826@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

  1. We can early report the config value error on set.
  2. We can use the config with strong type.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 884 files.

Valid Invalid Ignored Fixed
882 1 1 0
Click to see the invalid file list
  • src/common/src/session_config/mod.rs

src/common/src/session_config/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we support the show command later, do we need to write a large match arm that maps from show XXX's XXX to its getter function?

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang
Copy link
Collaborator Author

If we support the show command later, do we need to write a large match arm that maps from show XXX's XXX to its getter function?

Yes! Will add later

@TennyZhuang TennyZhuang added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #3568 (305880b) into main (e4c5f8b) will decrease coverage by 0.02%.
The diff coverage is 46.84%.

@@            Coverage Diff             @@
##             main    #3568      +/-   ##
==========================================
- Coverage   74.41%   74.38%   -0.03%     
==========================================
  Files         770      771       +1     
  Lines      108657   108700      +43     
==========================================
+ Hits        80852    80860       +8     
- Misses      27805    27840      +35     
Flag Coverage Δ
rust 74.38% <46.84%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/dml.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/query.rs 0.00% <0.00%> (ø)
src/frontend/src/lib.rs 50.00% <ø> (ø)
src/common/src/session_config/mod.rs 32.53% <32.53%> (ø)
src/common/src/session_config/query_mode.rs 100.00% <100.00%> (ø)
...ontend/src/optimizer/plan_node/stream_hash_join.rs 98.35% <100.00%> (+0.56%) ⬆️
src/frontend/src/session.rs 37.88% <100.00%> (-4.81%) ⬇️
src/common/src/types/ordered_float.rs 24.90% <0.00%> (+0.19%) ⬆️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.50%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit e39e0c9 into main Jun 30, 2022
@mergify mergify bot deleted the refactor/session-config-strong-type branch June 30, 2022 04:45
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* refactor(config): introduce strong type session config framework

Signed-off-by: TennyZhuang <zty0826@gmail.com>

* fix copyright

Signed-off-by: TennyZhuang <zty0826@gmail.com>

* refine ConfigI32

Signed-off-by: TennyZhuang <zty0826@gmail.com>

* clippy

Signed-off-by: TennyZhuang <zty0826@gmail.com>

* add missing flush

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants