-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(config): introduce strong type session config framework #3568
Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 884 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
882 | 1 | 1 | 0 |
Click to see the invalid file list
- src/common/src/session_config/mod.rs
Signed-off-by: TennyZhuang <zty0826@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we support the show
command later, do we need to write a large match arm that maps from show XXX
's XXX
to its getter function?
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Yes! Will add later |
Codecov Report
@@ Coverage Diff @@
## main #3568 +/- ##
==========================================
- Coverage 74.41% 74.38% -0.03%
==========================================
Files 770 771 +1
Lines 108657 108700 +43
==========================================
+ Hits 80852 80860 +8
- Misses 27805 27840 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
* refactor(config): introduce strong type session config framework Signed-off-by: TennyZhuang <zty0826@gmail.com> * fix copyright Signed-off-by: TennyZhuang <zty0826@gmail.com> * refine ConfigI32 Signed-off-by: TennyZhuang <zty0826@gmail.com> * clippy Signed-off-by: TennyZhuang <zty0826@gmail.com> * add missing flush Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang zty0826@gmail.com
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)