Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pgwire): add simple 'unrecognized_param' error handle #3592

Merged
merged 2 commits into from
Jul 2, 2022

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Jul 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Detail see : #3404

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@BowenXiao1999 BowenXiao1999 linked an issue Jul 1, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3592 (bb8de83) into main (c6629e1) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

❗ Current head bb8de83 differs from pull request most recent head 5881baf. Consider uploading reports for the commit 5881baf to get more accurate results

@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   74.38%   74.38%   -0.01%     
==========================================
  Files         771      771              
  Lines      109013   109026      +13     
==========================================
+ Hits        81089    81096       +7     
- Misses      27924    27930       +6     
Flag Coverage Δ
rust 74.38% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/pgwire/src/error.rs 0.00% <0.00%> (ø)
src/utils/pgwire/src/pg_protocol.rs 72.59% <20.00%> (-1.18%) ⬇️
src/meta/src/manager/id.rs 95.50% <0.00%> (-0.57%) ⬇️
src/frontend/src/expr/utils.rs 98.99% <0.00%> (ø)
src/storage/src/hummock/local_version_manager.rs 81.08% <0.00%> (+0.11%) ⬆️
src/storage/src/table/cell_based_table.rs 72.28% <0.00%> (+0.39%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@ZENOTME ZENOTME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BowenXiao1999 BowenXiao1999 force-pushed the bw/simple_error_handle_in_pgwire branch from 6734451 to bb8de83 Compare July 1, 2022 07:42
@BowenXiao1999 BowenXiao1999 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2022

Hey @BowenXiao1999, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue. More details can be found on the Queue: Embarked in merge train check-run.

@BowenXiao1999
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@BowenXiao1999 BowenXiao1999 force-pushed the bw/simple_error_handle_in_pgwire branch from 5881baf to 5f7c490 Compare July 2, 2022 06:33
@BowenXiao1999 BowenXiao1999 enabled auto-merge (squash) July 2, 2022 06:35
@BowenXiao1999 BowenXiao1999 merged commit ee8b0e8 into main Jul 2, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw/simple_error_handle_in_pgwire branch July 2, 2022 06:43
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* chore(pgwire): add simple 'unrecognized_param' error handle

* add some doc
@ZENOTME ZENOTME mentioned this pull request Jul 8, 2022
9 tasks
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…velabs#3592)

* chore(pgwire): add simple 'unrecognized_param' error handle

* add some doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants