refactor(state_table): construct state_table from table_id+store instead of key_space #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcy-fdu
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3593 +/- ##
==========================================
- Coverage 74.30% 74.29% -0.01%
==========================================
Files 773 773
Lines 109424 109551 +127
==========================================
+ Hits 81304 81394 +90
- Misses 28120 28157 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
wcy-fdu
commented
Jul 2, 2022
| ctx.internal_table_id_set.insert(node.table_id_h); | ||
| } | ||
|
|
||
| NodeBody::AppendOnlyTopN(node) => { |
There was a problem hiding this comment.
For append_only top_n, it use two internal state table_id_l and table_id_h, I'm not sure inserting two or three table_id for append_only top_n.
cc @st1page
There was a problem hiding this comment.
I think there should be two table id. but it is ok now that we waste one(not affect correctness). and later when we infer the table catalog in fe we can fix it.
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
…ead of key_space (#3593) * stage 1 * refactor state table new * refactor cell-based table new * fix * resolve conflict
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
…ead of key_space (risingwavelabs#3593) * stage 1 * refactor state table new * refactor cell-based table new * fix * resolve conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, change the
StateTable new()andCellBasedTable new()with table_id +store, instead of passing the wholekeyspace. Top_n has three internal state, so change the frontend to assign three table_id to top_n executor.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
close #3498