Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): allow accessing other vnodes from batch scan #3594

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. For READ_ONLY tables, accessing other vnodes is allowed and the row from point-get will be filtered out. This will make #3251 much cleaner.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@github-actions github-actions bot added the type/fix Bug fix label Jul 1, 2022
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao enabled auto-merge (squash) July 1, 2022 07:31
@BugenZhao BugenZhao merged commit c6629e1 into main Jul 1, 2022
@BugenZhao BugenZhao deleted the bz/vnode-in-key-part-7 branch July 1, 2022 07:34
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3594 (42af379) into main (00f54fa) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #3594      +/-   ##
==========================================
- Coverage   74.38%   74.38%   -0.01%     
==========================================
  Files         771      771              
  Lines      109016   109013       -3     
==========================================
- Hits        81094    81089       -5     
- Misses      27922    27924       +2     
Flag Coverage Δ
rust 74.38% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/table/cell_based_table.rs 71.88% <83.33%> (-0.40%) ⬇️
src/meta/src/manager/id.rs 95.50% <0.00%> (-1.13%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.25%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* fix(storage): allow accessing other vnodes from batch scan

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* add docs

Signed-off-by: Bugen Zhao <i@bugenzhao.com>

* fix doc

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants