Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): batch distinct agg & local topn distribution #3599

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

picked from ##3251

Checklist

Refer to a related PR or issue link (optional)

@xxchan xxchan requested review from fuyufjh and st1page July 1, 2022 09:18
@github-actions github-actions bot added the type/fix Bug fix label Jul 1, 2022
@xxchan xxchan requested a review from liurenjie1024 July 1, 2022 09:22
@xxchan xxchan added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3599 (639bb74) into main (c6629e1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3599      +/-   ##
==========================================
- Coverage   74.38%   74.38%   -0.01%     
==========================================
  Files         771      771              
  Lines      109013   109012       -1     
==========================================
- Hits        81089    81085       -4     
- Misses      27924    27927       +3     
Flag Coverage Δ
rust 74.38% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/optimizer/plan_node/batch_topn.rs 68.08% <0.00%> (-3.03%) ⬇️
...ontend/src/optimizer/plan_node/batch_simple_agg.rs 82.43% <75.00%> (-1.99%) ⬇️
src/meta/src/manager/id.rs 96.06% <0.00%> (ø)
src/frontend/src/expr/utils.rs 98.99% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 3ed921c into main Jul 1, 2022
@mergify mergify bot deleted the xxchan/controversial-ox branch July 1, 2022 10:07
@xxchan xxchan mentioned this pull request Jul 1, 2022
3 tasks
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* fix(optimizer): batch distinct agg & local topn distribution

* rerun
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…avelabs#3599)

* fix(optimizer): batch distinct agg & local topn distribution

* rerun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants