-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(streaming): create mview progress report under concurrent checkpoint #3602
fix(streaming): create mview progress report under concurrent checkpoint #3602
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM ❤️
Codecov Report
@@ Coverage Diff @@
## main #3602 +/- ##
==========================================
- Coverage 74.31% 74.30% -0.01%
==========================================
Files 772 772
Lines 109170 109180 +10
==========================================
+ Hits 81128 81129 +1
- Misses 28042 28051 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will test it with #3511
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the quick fix!
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
f26dac6
to
fc71592
Compare
Cool. You may merge this PR after tested. |
Seems this PR doesn't fully resolve the issue. Will remove "close" in PR body. |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
… of github.com:singularity-data/risingwave into bz/fix-create-mview-report-under-concurrent-checkpoint
…int (#3602) * fix(streaming): create mview progress report under concurrent checkpoint Signed-off-by: Bugen Zhao <i@bugenzhao.com> * refine docs Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: Xinhao Xu <84456268+xxhZs@users.noreply.github.com>
…int (risingwavelabs#3602) * fix(streaming): create mview progress report under concurrent checkpoint Signed-off-by: Bugen Zhao <i@bugenzhao.com> * refine docs Signed-off-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: Xinhao Xu <84456268+xxhZs@users.noreply.github.com>
Signed-off-by: Bugen Zhao i@bugenzhao.com
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. See #3598 for more details.
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)