-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add sampled (de)serialization duration metrics for RPC #3618
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3618 +/- ##
==========================================
- Coverage 74.38% 74.37% -0.02%
==========================================
Files 776 776
Lines 110110 110155 +45
==========================================
+ Hits 81905 81926 +21
- Misses 28205 28229 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this metrics is only used within scale service, and should not be put in dashboard.
No metric is used in all services. And since the panels of these two metrics locate in the "streaming actors" section, where most metrics that the scaling service needs locate, developers who do not care for scaling service can easily fold and unsee this section. |
The metrics you added do not convey any actual meaning. If developers observe "30ms" from the metrics, what can they know about the system? |
... and thus it's better not to add it to dashboard. |
IMO, since sampling is used, the important information is not the accurate number but the existence and trend. If the graph of this metric exists, developers can know that this metric is not been disrupted. If this metric is growing, developers can know how the (de)serialization durations change. |
If we want to explore trend, we should use
It will change as long as there's an exchange. There's no need to have yet another metrics to prove a fact.
You can just leave it on your local branch, instead of merging into main. |
With the rapid development, rebase can be miserable. Also, others who also develop the scaling service can benefit from it. I don't think this brings more overhead than its benefits. |
I'd only approve for the changes of metrics and not the dashboard. You can find another reviewer who agree on you. |
Thanks for your review of the changes of metrics. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Add sampled (de)serialization duration metrics for RPC with the given frequency
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)
#3284