Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cell_based_table): decouple encoding and cell_based table #3619

Merged
merged 6 commits into from
Jul 4, 2022

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Jul 4, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR is the preparation of row-based encoding.

  • decouple encoding and cell-based table.
  • rename CellBasedTable to StorageTable.

Subsequent PR will do the following:

  • refactor StorageTableIter with trait RowEncoding.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

part of #3616

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #3619 (838d14c) into main (06b3c11) will decrease coverage by 0.00%.
The diff coverage is 80.85%.

@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
- Coverage   74.35%   74.35%   -0.01%     
==========================================
  Files         775      775              
  Lines      110074   110084      +10     
==========================================
+ Hits        81845    81850       +5     
- Misses      28229    28234       +5     
Flag Coverage Δ
rust 74.35% <80.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 13.90% <0.00%> (ø)
...torage/src/encoding/cell_based_row_deserializer.rs 88.00% <ø> (ø)
...c/encoding/dedup_pk_cell_based_row_deserializer.rs 92.26% <ø> (ø)
src/storage/src/error.rs 0.00% <ø> (ø)
src/storage/src/lib.rs 100.00% <ø> (ø)
src/storage/src/table/mod.rs 100.00% <ø> (ø)
src/storage/src/table/storage_table/iter_utils.rs 87.75% <ø> (ø)
src/stream/src/from_proto/batch_query.rs 0.00% <0.00%> (ø)
src/storage/src/table/storage_table.rs 71.94% <77.77%> (ø)
...src/encoding/dedup_pk_cell_based_row_serializer.rs 92.39% <81.25%> (ø)
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/storage/src/error.rs Outdated Show resolved Hide resolved
src/storage/src/table/storage_table.rs Outdated Show resolved Hide resolved
src/storage/src/encoding/row_serializer.rs Outdated Show resolved Hide resolved
@wcy-fdu wcy-fdu requested a review from BugenZhao July 4, 2022 07:31
@wcy-fdu wcy-fdu enabled auto-merge (squash) July 4, 2022 08:14
@wcy-fdu wcy-fdu merged commit 030a2f8 into main Jul 4, 2022
@wcy-fdu wcy-fdu deleted the wcy_decouple_encoding branch July 4, 2022 08:19
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…isingwavelabs#3619)

* decouple encoding and rename cell_based table

* update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants