fix(expr): fix interval div float #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shmiwy <wyf000219@126.com>
shmiwy
requested review from
jon-chuang and
xiangjinwu
and removed request for
jon-chuang
added 2 commits
July 4, 2022 18:04
Signed-off-by: Shmiwy <wyf000219@126.com>
Codecov Report
@@ Coverage Diff @@
## main #3631 +/- ##
=======================================
Coverage 74.37% 74.37%
=======================================
Files 776 776
Lines 110155 110163 +8
=======================================
+ Hits 81927 81934 +7
- Misses 28228 28229 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
skyzh
reviewed
Jul 4, 2022
src/common/src/types/interval.rs
Outdated
| @@ -196,7 +196,10 @@ impl IntervalUnit { | |||
| } | |||
|
|
|||
| let months = (self.months as f64) / rhs; | |||
| let days = (self.days as f64) / rhs + (months % 1.0) * 30.0; | |||
| let mut days = (self.days as f64) / rhs + (months % 1.0) * 30.0; | |||
| if (days - days.round()).abs() <= 0.0000001 { | |||
There was a problem hiding this comment.
Use https://doc.rust-lang.org/std/primitive.f64.html#associatedconstant.EPSILON instead?
days.fract().abs() < f64::EPSILON
added 6 commits
July 4, 2022 19:29
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
…wave into interval_mul_float
skyzh
approved these changes
Jul 4, 2022
skyzh
added
the
mergify/can-merge
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
* fix(expr): fix interval div float Signed-off-by: Shmiwy <wyf000219@126.com> * fix(expr): fix interval div float Signed-off-by: Shmiwy <wyf000219@126.com> * fix(expr): fix interval div float Signed-off-by: Shmiwy <wyf000219@126.com> * fix(expr): fix interval div float Signed-off-by: Shmiwy <wyf000219@126.com> * fix(expr): fix interval div float Signed-off-by: Shmiwy <wyf000219@126.com> * fix(expr): fix interval div float Signed-off-by: Shmiwy <wyf000219@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shmiwy wyf000219@126.com
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
where we should get
2 mons 12 days 00:00:00https://github.com/singularity-data/risingwave/blob/722ba98b33fe87e8de028d31d57f7bd63d6bcd63/src/common/src/types/interval.rs#L199
float are not exact in computer, so it is not advisable to use float numbers directly for mod and division operations. Thus, the month numbers are inexact. As in the example above, where we should get 12.0, but often we get 11.99999999
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
#3341