fix(parser): disallow empty object names #8171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
changed the title
xxchan
reviewed
Feb 25, 2023
| where | ||
| S: Into<String>, | ||
| { | ||
| assert!(quote == '\'' || quote == '"' || quote == '`' || quote == '['); |
There was a problem hiding this comment.
I think we can keep the assertion?
There was a problem hiding this comment.
Well, if the function name is _unchecked, doesn't seem coherent to add assertions.
src/sqlparser/src/ast/mod.rs
Outdated
| Ident { | ||
| value: value.into(), | ||
| quote_style: Some(quote), | ||
| } | ||
| } | ||
|
|
||
| /// Create a new quoted identifier with the given quote and value. | ||
| /// returns ParserError when the given string is empty or the given quote is illegal. | ||
| pub fn new_with_quote_check<S>(quote: char, value: S) -> Result<Ident, ParserError> |
There was a problem hiding this comment.
Where is this function used? I didn't find that
There was a problem hiding this comment.
shoud I remove this function? it might be useful, and I just found this asymmetry jarring defining only a unchecked function
xxchan
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #6022
Checklist For Contributors
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)./risedev check(or alias,./risedev c)Checklist For Reviewers
[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note