Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics): add instance info for read avg of object operation #8191

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Feb 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

as titled

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

@github-actions github-actions bot added type/chore user-facing-changes Contains changes that are visible to users labels Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #8191 (96725bb) into main (db53272) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8191   +/-   ##
=======================================
  Coverage   71.78%   71.79%           
=======================================
  Files        1130     1130           
  Lines      181508   181508           
=======================================
+ Hits       130295   130305   +10     
+ Misses      51213    51203   -10     
Flag Coverage Δ
rust 71.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...torage/src/hummock/local_version/pinned_version.rs 88.75% <0.00%> (-0.63%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.46% <0.00%> (-0.52%) ⬇️
src/object_store/src/object/mod.rs 48.65% <0.00%> (-0.21%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.77% <0.00%> (-0.16%) ⬇️
src/common/src/cache.rs 97.15% <0.00%> (-0.11%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.88% <0.00%> (+0.19%) ⬆️
src/batch/src/task/task_execution.rs 52.13% <0.00%> (+0.50%) ⬆️
src/storage/src/hummock/sstable/xor_filter.rs 98.76% <0.00%> (+1.23%) ⬆️
src/batch/src/executor/group_top_n.rs 74.70% <0.00%> (+6.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KeXiangWang KeXiangWang added this pull request to the merge queue Feb 27, 2023
Merged via the queue into main with commit b54d177 Feb 27, 2023
@KeXiangWang KeXiangWang deleted the wkx-object-read-duration-metrics branch February 27, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants