feat(streaming): watermark on append only table #8207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hao/watermark_append_only_table
Codecov Report
@@ Coverage Diff @@
## main #8207 +/- ##
==========================================
- Coverage 71.70% 71.70% -0.01%
==========================================
Files 1131 1131
Lines 182341 182390 +49
==========================================
+ Hits 130748 130775 +27
- Misses 51593 51615 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
st1page
approved these changes
Feb 27, 2023
| @@ -13,3 +13,13 @@ | |||
| └─StreamRowIdGen { row_id_index: 1 } | |||
| └─StreamWatermarkFilter { watermark_descs: [idx: 0, expr: (v1 - '00:00:01':Interval)] } | |||
| └─StreamSource { source: "t", columns: ["v1", "_row_id"] } | |||
| - name: watermark on append only table | |||
| sql: | | |||
| explain create table t (v1 timestamp with time zone, watermark for v1 as v1 - INTERVAL '1' SECOND) with (connector = 'kafka', kafka.topic = 'kafka_3_partition_topic', kafka.brokers = '127.0.0.1:1234', kafka.scan.startup.mode='earliest', appendonly=true) ROW FORMAT JSON; | |||
There was a problem hiding this comment.
emm, our usual usage is without the external connector. So maybe removing it is better?
There was a problem hiding this comment.
I think we can keep both behaviors undocumented for test. I'll add a new planner test.
xx01cyx
reviewed
Feb 28, 2023
yuhao-su
commented
Feb 28, 2023
Comment on lines
+468
to
+475
| if !append_only && !watermark_descs.is_empty() { | ||
| return Err(ErrorCode::NotSupported( | ||
| "Defining watermarks on table requires the table to be append only.".to_owned(), | ||
| "Set the option `appendonly=true`".to_owned(), | ||
| ) | ||
| .into()); | ||
| } | ||
|
|
There was a problem hiding this comment.
@xx01cyx append only part
yuhao-su
changed the title
BugenZhao
reviewed
Feb 28, 2023
Comment on lines
+361
to
+365
| if let Some(catalog) = self.source_catalog() && !catalog.watermark_descs.is_empty() && !self.core.for_table{ | ||
| plan = StreamWatermarkFilter::new(plan, catalog.watermark_descs.clone()).into(); | ||
| } | ||
|
|
||
| assert!(!(self.core.gen_row_id && self.core.for_table)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist For Contributors
Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note