Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): disable single-quoted strings as aliases for column or table #8338

Merged
merged 4 commits into from Mar 5, 2023
Merged

fix(parser): disable single-quoted strings as aliases for column or table #8338

merged 4 commits into from Mar 5, 2023

Conversation

Eridanus117
Copy link
Contributor

@Eridanus117 Eridanus117 commented Mar 5, 2023 •
edited

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

disable single-quoted strings as aliases for column or table

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

disable single-quoted strings as aliases for column or table

@Eridanus117 Eridanus117 mentioned this pull request Mar 5, 2023
Closed
@Eridanus117 Eridanus117 changed the title fix(parser): disable single quoteed alias fix(parser): disable single-quoted strings as aliases for column or table Mar 5, 2023
@Eridanus117 Eridanus117 marked this pull request as ready for review March 5, 2023 05:51
xxchan
xxchan reviewed Mar 5, 2023
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case for it?

@Eridanus117 Eridanus117 requested a review from xxchan March 5, 2023 11:35
xxchan
xxchan approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@xxchan xxchan added this pull request to the merge queue Mar 5, 2023
Merged via the queue into risingwavelabs:main with commit cb2c85f Mar 5, 2023
@Eridanus117 Eridanus117 deleted the disable_single_quoteed_alias branch March 5, 2023 14:46
@Eridanus117
Copy link
Contributor Author

#8184
cite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eridanus117 @xxchan