Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run complex query containing system tables in local mode #8797

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Mar 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #8791
Previously, setops like UNION, and subquery are not considered.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@xxchan xxchan requested review from chenzl25 and st1page March 27, 2023 14:45
@github-actions github-actions bot added the type/fix Bug fix label Mar 27, 2023
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan marked this pull request as draft March 27, 2023 14:53
@xxchan
Copy link
Member Author

xxchan commented Mar 27, 2023

Oops, the query for complete SHOW is still not fixed 🥵🥵🥵🥵🥵🥵🥵

because of Relation::contains_sys_table is wrong

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #8797 (d1b9f09) into main (116cc11) will decrease coverage by 0.01%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main    #8797      +/-   ##
==========================================
- Coverage   70.79%   70.79%   -0.01%     
==========================================
  Files        1171     1171              
  Lines      193220   193225       +5     
==========================================
+ Hits       136785   136787       +2     
- Misses      56435    56438       +3     
Flag Coverage Δ
rust 70.79% <73.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/query.rs 10.74% <50.00%> (-1.38%) ⬇️
src/frontend/src/binder/set_expr.rs 62.38% <63.63%> (+0.14%) ⬆️
src/frontend/src/binder/query.rs 97.27% <100.00%> (+0.05%) ⬆️
src/frontend/src/binder/relation/mod.rs 74.77% <100.00%> (+1.17%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan marked this pull request as ready for review March 27, 2023 15:11
@xxchan xxchan changed the title fix: run in local mode when system tables are contained fix: run complex query containing system tables in local mode Mar 27, 2023
@xxchan xxchan enabled auto-merge March 27, 2023 15:14
@xxchan xxchan added this pull request to the merge queue Mar 27, 2023
Merged via the queue into main with commit ceebdeb Mar 27, 2023
@xxchan xxchan deleted the xxchan/fortunate-marten branch March 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panics when hit tab after SHOW
2 participants